[Bug 226126] Merge Review: man-pages-ja

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: man-pages-ja


https://bugzilla.redhat.com/show_bug.cgi?id=226126


bugzilla at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium
           Priority|normal                      |medium
            Product|Fedora Extras               |Fedora

panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?




------- Additional Comments From panemade at gmail.com  2007-09-21 05:52 EST -------
Preliminary review =>
rpmlint on SRPM gave me
man-pages-ja.src:43: W: rpm-buildroot-usage %build perl %{SOURCE1}
$RPM_BUILD_ROOT | make
$RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it
will break short circuiting.

rpmlint on RPM gave me
man-pages-ja.noarch: W: file-not-utf8
/usr/share/doc/man-pages-ja-20070815/translation_lists/SysVinit.translation_list
The character encoding of this file is not UTF-8.  Consider converting it
in the specfile for example using iconv(1).
for all the files in /usr/share/doc/man-pages-ja-20070815/translation_lists/

also,
  Dunno why so many messages in build.log
Use of uninitialized value in numeric comparison (<=>) at script/configure.perl
line 239.

SHOULD:
   preserve timestamps.
   use %defattr(-,root,root,-)
   Update to new upstream release.  
      http://www.linux.or.jp/JM/man-pages-ja-20070915.tar.gz
   Use disttag
    

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.