[Bug 244031] Review Request: qfits - A stand-alone general purpose FITS library
bugzilla at redhat.com
bugzilla at redhat.com
Fri Sep 21 16:59:05 UTC 2007
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: qfits - A stand-alone general purpose FITS library
https://bugzilla.redhat.com/show_bug.cgi?id=244031
mtasaka at ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|nobody at fedoraproject.org |mtasaka at ioa.s.u-tokyo.ac.jp
Status|NEW |ASSIGNED
Flag| |fedora-review?
------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp 2007-09-21 12:59 EST -------
For 6.2.0-1:
! Naming suggestion
- Well, IMO it is better that
* qfits should be renamed to qfits-libs
* qfits-libs should be renamed to qfits
* Requires for /sbin/ldconfig
- "Requires(post,postun): /sbin/ldconfig" is not needed.
(Still %post, %postun themselves are needed)
* defattr
- We now recommend %defattr(-,root,root,-)
* Timestamps
- For keeping timestamps, I recommend
-----------------------------------------------------
%{__make} DESTDIR=%{buildroot} INSTALL="%{__install} -p" install
------------------------------------------------------
This will keep timestamps on installed header files and
man files
! Note: The method above usually works on recent Makefile.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list