[Bug 244171] Review Request: SteGUI - SteGUI is a graphical front-end to Steghide

bugzilla at redhat.com bugzilla at redhat.com
Sun Sep 23 01:30:24 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: SteGUI - SteGUI is a graphical front-end to Steghide


https://bugzilla.redhat.com/show_bug.cgi?id=244171


michel.sylvan at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|177841                      |
              nThis|                            |
         AssignedTo|nobody at fedoraproject.org    |michel.sylvan at gmail.com
             Status|NEW                         |ASSIGNED




------- Additional Comments From michel.sylvan at gmail.com  2007-09-22 21:30 EST -------
That icon is actually from the 'esc' package -- so if you want to use it, you
should probably package it yourself. Probably need permission from the author
though. How about this image, from Wikipedia's Steganography article?

http://en.wikipedia.org/wiki/Image:Inkblot.svg

The advantage is that Wiki pictures are free of copyright restrictions so we're
safe using that.

You don't need to hardcode the path in Exec= and Icon= , so just

Exec=SteGUI
Icon=foo

is enough. Note that the extension for the icon should be left out as well, that
way if an icon theme comes along with, say, SVG icons, your desktop file does
not need updating (see http://fedoraproject.org/wiki/Packaging/Guidelines)

One last thing -- for Comment you probably want to say "Hides and extracts
information within files" (describes what the program does), and for
GenericName, "Steganography tool"? Not that GenericName is really used right now
(it might be used by the KDE panel, not sure).

Perhaps you could include French translations in the desktop file as well, to
match the French translations in the spec file?

Apart from that, ready to go. Pity that steghide itself is currently broken :(

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list