[Bug 300651] Review Request: baekmuk-ttf-fonts - Korean truetype fonts (from fonts-korean)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: baekmuk-ttf-fonts - Korean truetype fonts (from fonts-korean)


https://bugzilla.redhat.com/show_bug.cgi?id=300651





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-09-23 21:24 EST -------
(In reply to comment #6)
> (In reply to comment #5)
> > * Use "-p" option for "cp" or "install" to keep timestamp
> 
> Not sure what you mean here: I don't see any cp usage currently in .spec.

* For example,
--------------------------------------------------------
  install -m 0644 ttf/$i.ttf $RPM_BUILD_ROOT%{ttfontdir}-$i
--------------------------------------------------------
  Here "install -m 0644" should be "install -p -m 0644".

> 
> > ? So FAPIcidfmap.ko and cidfmap.ko, COPYRIGHT* README are instaled
> >   in each subpackage?
> 
> Currently, yes.  Installing the CID fmap files in each package is not ideal,
> but I can't see a better way without introducing some messy scripts say
> and it should not have any particular adverse affects I think.

* I think you should 
  - introduce a base package (say: "baekmuk-ttf-fonts-base"), 
  - and have CIP fmap, copying file and other files owned by -base
    package
  - and have other subpackages require -base package.

 
> > ? Why can each subpackage have "Provides: ttfonts-ko = %{ttfontverhead}"?
> >   I guess only when all subpackages are installed, they can provide
> >   "ttfonts-ko = %{ttfontverhead}" for consistency with the state before
> >   kkfonts related packages are seperated?
> 
> Ok, let me remove the Provides.
? This means you will write "Provides: ttfonts-ko = <somever>" in
  original fonts-korean package (and make fonts-korean require
  all baekmuk fonts subpackages)?

> Spec URL: http://fedorapeople.org/petersen/baekmuk-ttf/baekmuk-ttf-fonts.spec
? By the way the URL above is not accessible from me. Instead
  http://petersen.fedorapeople.org/baekmuk-ttf/baekmuk-ttf-fonts.spec
  works.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.