[Bug 225242] Merge Review: alsa-utils
bugzilla at redhat.com
bugzilla at redhat.com
Mon Sep 24 13:29:20 UTC 2007
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Merge Review: alsa-utils
https://bugzilla.redhat.com/show_bug.cgi?id=225242
matthias at rpmforge.net changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CLOSED |ASSIGNED
Keywords| |Reopened
Resolution|NEXTRELEASE |
------- Additional Comments From matthias at rpmforge.net 2007-09-24 09:29 EST -------
Additional cleanups :
- Pick either tabs or spaces for identing, but not both.
- Why is the -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 still needed? The
configure script only has a "--disable-largefile" option, so I'd assume it's
enabled by default. If it's still needed, a quick comment would be a good thing.
- The "/var/lib/alsa" line would be clearer as "%dir /var/lib/alsa/" since
nothing below it is included (only asound.state, but it's %ghost'ed).
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list