[Bug 304861] Review Request: eclipse-demos - Eclipse screencasts

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: eclipse-demos - Eclipse screencasts


https://bugzilla.redhat.com/show_bug.cgi?id=304861





------- Additional Comments From tibbs at math.uh.edu  2007-09-25 15:57 EST -------
This is pretty much trivial.  rpmlint says:

eclipse-demos.noarch: W: invalid-license Open Publication License

According to http://fedoraproject.org/wiki/Licensing, the License: tag should be
"Open Publication".  This license is also only acceptable without the optional
clauses in the sixth section.  Actually I can't tell if anything in the sixth
section of the license applies at all, because those options are supposed to be
used in the incorporation by reference, and there's nothing to attach such a
reference to unless they're in the oggs somehow.  I'm going to assume not.

Also, you should %doc the license file.

The only other question I have is regarding the totem requirement.  I can view
this without using totem (from a KDE system, say, or one with mplayer), and I
could just serve the files via the web or something.  Frankly I'd just drop it.

* source files match upstream:
   0a3a42da854f4f20c93baa80658ade0c08b9ae66edfc174343f9ba41f9605655  
   eclipse-demos-0.0.1.tar.bz2
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license (but should use approved short form)
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper (none)
* %clean is present.
* package builds in mock (x86_64, development).
* package installs properly
X rpmlint has a valid complaint.
? final provides and requires; totem probably shouldn't be there.
  eclipse-demos-0.0.1-1.fc8.noarch.rpm
   eclipse-demos = 0.0.1-1.fc8
  =
?  totem
* %check is not present; a test suite isn't really applicable.  I watched a 
  couple of the videos and they look OK to me.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.