[Bug 305741] Review Request: fedora-icon-theme - Fedora icon theme
bugzilla at redhat.com
bugzilla at redhat.com
Tue Sep 25 20:55:12 UTC 2007
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: fedora-icon-theme - Fedora icon theme
https://bugzilla.redhat.com/show_bug.cgi?id=305741
notting at redhat.com changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|mclasen at redhat.com |notting at redhat.com
Flag| |fedora-review?
------- Additional Comments From notting at redhat.com 2007-09-25 16:55 EST -------
MUST items:
- Package meets naming and packaging guidelines - OK
- Spec file matches base package name. - OK
- Spec has consistant macro usage. - OK
- Meets Packaging Guidelines. - OK
- License - OK
- License field in spec matches - ***
Should be GPL+. Of course, not much copyrightable here.
- License file included in package - OK
- Spec in American English - OK
- Spec is legible. - OK
- BuildRequires correct - ***
Needs perl(XML::Parser)
- Spec handles locales/find_lang - OK
- Package has %defattr and permissions on files is good. - OK
- Package has a correct %clean section. - OK
- Package has correct buildroot - OK
- Package is code or permissible content. - OK
- Packages %doc files don't affect runtime. - OK
- Package compiles and builds on at least one arch - tested x86_64
- Package has no duplicate files in %files. - OK
- Package doesn't own any directories other packages own. - OK
- Package owns all the directories it creates. - OK
- No rpmlint output. - ***
fedora-icon-theme.noarch: E: zero-length /usr/share/doc/fedora-icon-theme-1.0.0/NEWS
fedora-icon-theme.noarch: E: zero-length
/usr/share/doc/fedora-icon-theme-1.0.0/ChangeLog
fedora-icon-theme.noarch: E: zero-length
/usr/share/doc/fedora-icon-theme-1.0.0/README
Can be removed.
fedora-icon-theme.noarch: W: invalid-license GPL
See above.
- final provides and requires are sane:
I don't see any reason why this requires system-logos. What it probably
should require is mist-icon-theme or gnome-icon-theme, as that's what it
inherits from.
Should probably provide system-icon-theme, as well.
SHOULD Items:
- Should build in mock. - See above about buildreqs
- Should function as described. - didn't test
- Should have sane scriptlets. - OK
- Should have dist tag - OK
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the Fedora-package-review
mailing list