[Bug 226472] Merge Review: system-config-users

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: system-config-users


https://bugzilla.redhat.com/show_bug.cgi?id=226472


bugzilla at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium
           Priority|normal                      |medium
            Product|Fedora Extras               |Fedora

panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?




------- Additional Comments From panemade at gmail.com  2007-09-28 11:53 EST -------
picking up this for review.

rpmlint on SRPM and RPM gave 
--------------------------------
system-config-users.src:18: W: unversioned-explicit-obsoletes redhat-config-users
The specfile contains an unversioned Obsoletes: token, which will match all
older, equal and newer versions of the obsoleted thing.  This may cause update
problems, restrict future package/provides naming, and may match something it
was originally not inteded to match -- make the Obsoletes versioned if
possible.

system-config-users.noarch: E: non-executable-script
/usr/share/system-config-users/system-config-users.py 0644
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

system-config-users.noarch: W: incoherent-version-in-changelog 1.2.68 1.2.68-1.fc8
The last entry in %changelog contains a version identifier that is not
coherent with the epoch:version-release tuple of the package.

system-config-users.noarch: W: obsolete-not-provided redhat-config-users
If a package is obsoleted by a compatible replacement, the obsoleted package
must also be provided in order to provide clean upgrade paths and not cause
unnecessary dependency breakage.  If the obsoleting package is not a compatible
replacement for the old one, leave out the provides.

system-config-users.noarch: W: conffile-without-noreplace-flag
/etc/pam.d/system-config-users
A configuration file is stored in your package without the noreplace flag.
A way to resolve this is to put the following in your SPEC file:

%config(noreplace) /etc/your_config_file_here


system-config-users.noarch: W: conffile-without-noreplace-flag
/etc/security/console.apps/system-config-users
A configuration file is stored in your package without the noreplace flag.
A way to resolve this is to put the following in your SPEC file:

%config(noreplace) /etc/your_config_file_here


Also,
  1) good to use %defattr(-,root,root,-)
  2) any reason for not using macros for following line om %files section
   /usr/bin/system-config-users
   %dir /usr/share/system-config-users
   /usr/share/system-config-users/*
  3) packaging guidelines suggest use of make as
http://fedoraproject.org/wiki/Packaging/Guidelines#head-525c7d76890cb22df33b759c65c35c82bf434d2e
    
 



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.