[Bug 302361] Review Request: freecol - The FreeCol multi-player strategy game
bugzilla at redhat.com
bugzilla at redhat.com
Sat Sep 29 15:16:51 UTC 2007
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: freecol - The FreeCol multi-player strategy game
https://bugzilla.redhat.com/show_bug.cgi?id=302361
ville.skytta at iki.fi changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|nobody at fedoraproject.org |ville.skytta at iki.fi
Status|NEW |ASSIGNED
Flag| |fedora-review?
------- Additional Comments From ville.skytta at iki.fi 2007-09-29 11:16 EST -------
Initial notes, not yet a full review:
Doesn't Java 1.7 include the StAX APIs and a reference implementation? That
would probably make all dependencies on wstx superfluous. In fact, the package
builds fine with the dependencies removed and no wstx available. I don't have a
setup where this could be tested at runtime, but at least build without wstx
succeeds.
Hardwired Class-Path entries in jar manifests are generally frowned upon, and in
this case they point to stuff in the jars/ subdir which won't exist as
freecol.jar is installed to /usr/share/java and the startup script takes care of
the classpath. So they should be removed.
The Encoding key in the desktop entry is deprecated, and could be removed.
rpmlint:
freecol-manual.noarch: E: zero-length /usr/share/doc/freecol-manual-0.7.2/img2.png
freecol-manual.noarch: E: zero-length /usr/share/doc/freecol-manual-0.7.2/img1.png
freecol-manual.noarch: E: zero-length /usr/share/doc/freecol-manual-0.7.2/img3.png
Intentional?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the Fedora-package-review
mailing list