[Bug 291191] Review Request: XGrep - A grep-like utility for XML files.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: XGrep - A  grep-like utility for XML files.


https://bugzilla.redhat.com/show_bug.cgi?id=291191


mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-09-29 12:29 EST -------
First:
! Please change the release number of your spec/srpm each time
  you modify your spec/srpm.

  http://fedoraproject.org/wiki/Packaging/FrequentlyMadeMistakes

Then for 0.06-1:
* Redundant Requires
  - "Requires: pcre" is not needed. rpmbuild checks dependency for
    libraries automatically and dependency for libpcre.so.0 automatically
    pulls pcre package

! Please consider if version specific dependency for libxml2(-devel) is
  really useful.
  Even RH9 (more than 4 years ago) has libxml2-2.5.4-1.
  "BuildRequires: libxml2-devel" is sufficient and "Requires: libxml2"
  is not needed, IMO

* Source URL
  - Source0 returns 404 (not found).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.