[Bug 253549] Review Request: TzClock - GTK+ Time Zone Clock

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: TzClock - GTK+ Time Zone Clock


https://bugzilla.redhat.com/show_bug.cgi?id=253549





------- Additional Comments From chris at theknight.co.uk  2007-09-29 16:55 EST -------
(In reply to comment #7)
> * rpmlint is not silent:
> tzclock-debuginfo.x86_64: E: empty-debuginfo-package
debuginfo package removed.
> tzclock.src: E: invalid-spec-name TzClock.spec
spec file reverted to lowercase.
> * you should use %{?dist} macro in Release tag
Done, always wondered how it should be done.
> * package fails to build in mock; missing BR: libgnomeui-devel
Added build requirement, all this for a link on the about box.
> * you should include AUTHORS and COPYING files in %doc
Done.
> * IMO you should change all names to lowercase to improve usability
spec file at least is lowercase.
> * IANAL but this doesn't look like GPLv2
Oooops my auto comment program caught me out.

Thanks for your feedback, it is very helpful.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.