[Bug 436611] Review Request: perl-XML-Entities - Decode strings with XML entities

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-XML-Entities - Decode strings with XML entities


https://bugzilla.redhat.com/show_bug.cgi?id=436611


xavier at bachelot.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |xavier at bachelot.org
               Flag|                            |fedora-review?




------- Additional Comments From xavier at bachelot.org  2008-04-03 08:46 EST -------
+ spec file is legible
+ spec file name is OK
+ package name is OK
= trailing spaces in Summary:
+ License: matches upstream and is acceptable 
+ URL: is OK
+ Source: match upstream : 5081067743a516312dcf6a5c2b15db8e
+ latest version is packaged
= additional source generation is explained and can be reproduced, however the
tarball doesn't have the same MD5 hash as in the SRPM.
= the generated tarball name should be prefixed with the package name
+ BuildRoot: is OK
= the sed command would be better suited in the %%prep section, but it may not
be easily doable, I didn't look closely
+ macro usage is consistent
+ builds fine in mock F8 i386
+ all test succeed
+ docs are included and are not needed for the soft to run
+ package owns the dirs it creates
+ rpmlint output is empty
+ final Provides: looks good
+ final Requires: looks good
- BR:s perl(ExtUtils::Command::MM) perl(ExtUtils::MY) are not needed

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.