[Bug 440393] Review Request: python-lzo - Python bindings for lzo
bugzilla at redhat.com
bugzilla at redhat.com
Fri Apr 4 03:38:19 UTC 2008
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: python-lzo - Python bindings for lzo
https://bugzilla.redhat.com/show_bug.cgi?id=440393
panemade at gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
------- Additional Comments From panemade at gmail.com 2008-04-03 23:38 EST -------
Review:
+ package builds in mock.
Koji build =>
dist-f8 build: http://koji.fedoraproject.org/koji/taskinfo?taskID=547587
dist-f9 build: http://koji.fedoraproject.org/koji/taskinfo?taskID=547582
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream.
292a3b6cdaca606b917e7f6bf026fdad python-lzo-1.08.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ Package python-lzo-1.08-2.fc9=>
Provides: lzo.so
Requires: libc.so.6 libc.so.6(GLIBC_2.1.3) liblzo2.so.2 libpthread.so.0
libpython2.5.so.1.0 python(abi) = 2.5 rtld(GNU_HASH)
+ Not a GUI app.
APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the Fedora-package-review
mailing list