[Bug 417511] Review Request: jruby - Pure Java implementation of the Ruby interpreter

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: jruby - Pure Java implementation of the Ruby interpreter


https://bugzilla.redhat.com/show_bug.cgi?id=417511





------- Additional Comments From walters at redhat.com  2008-04-07 22:38 EST -------
* source files match upstream:
89c41db323d6859021cdbc1747b3498c21c9739b  /tmp/jruby-src-1.1.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text in tarball but not included in package.
* latest version is being packaged.
? BuildRequires are proper (can't build in mock yet)
* %clean is present.
? package builds in mock (rawhide, x86_64).
* package installs properly
* rpmlint clean
X %check is not present, but there is a test suite upstream
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* %docs are not necessary for the proper functioning of the package.
X No comment above patches; see
http://fedoraproject.org/wiki/PackagingDrafts/PatchUpstreamStatus

Java-specific bits:
* no pre-built jars
* single jar, named after the package
* jarfiles are under _javadir.



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.