[Bug 440679] Review Request: lua-sql - Database connectivity for Lua

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: lua-sql - Database connectivity for Lua


https://bugzilla.redhat.com/show_bug.cgi?id=440679


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From tibbs at math.uh.edu  2008-04-08 00:20 EST -------
luaforge.net is back up now, so....

rpmlist says:

  lua-sql.x86_64: E: no-binary
This is true, and is not a problem.

  lua-sql-mysql.x86_64: W: no-documentation
  lua-sql-postgresql.x86_64: W: no-documentation
  lua-sql-sqlite.x86_64: W: no-documentation
These are all OK as well; the documentation is in a separate package.

The base package containing only the README file is kind of odd.  Honestly I
don't really see the point of having it at all; I'd just put the README file in
the -doc package and dispense with the base package altogether.  But I don't
really see any problem with it.

I note that there's some sort of test suite.  Usually database tests can't
really be run at build time and I'm going to assume that's the case here, but if
 if they do happen to be runnable it would be good for you to add a %check section.

* source files match upstream:
   608c79e84bb9a348ed2a9375a4e7ba4d42615c8b8ef6959c014661ddd9eda765  
   luasql-2.1.1.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summaries are OK.
* descriptions are OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* debuginfo package looks complete.
* rpmlint has acceptable complaints.
* final provides and requires are sane:
  lua-sql-2.1.1-3.fc9.x86_64.rpm
   lua-sql = 2.1.1-3.fc9
  =
   lua-sql-doc
   lua-sql-mysql
   lua-sql-postgresql
   lua-sql-sqlite

  lua-sql-doc-2.1.1-3.fc9.x86_64.rpm
   lua-sql-doc = 2.1.1-3.fc9
  =
   lua >= 5.1

  lua-sql-mysql-2.1.1-3.fc9.x86_64.rpm
   mysql.so()(64bit)
   lua-sql-mysql = 2.1.1-3.fc9
  =
   libmysqlclient.so.15()(64bit)
   libmysqlclient.so.15(libmysqlclient_15)(64bit)
   lua >= 5.1

  lua-sql-postgresql-2.1.1-3.fc9.x86_64.rpm
   postgres.so()(64bit)
   lua-sql-postgresql = 2.1.1-3.fc9
  =
   libpq.so.5()(64bit)
   lua >= 5.1

  lua-sql-sqlite-2.1.1-3.fc9.x86_64.rpm
   sqlite3.so()(64bit)
   lua-sql-sqlite = 2.1.1-3.fc9
  =
   libsqlite3.so.0()(64bit)
   lua >= 5.1

* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* no headers.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.