[Bug 440680] Review Request: lua-logging - A simple API to use logging features in Lua

bugzilla at redhat.com bugzilla at redhat.com
Thu Apr 10 18:16:13 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: lua-logging - A simple API to use logging features in Lua


https://bugzilla.redhat.com/show_bug.cgi?id=440680


michel.sylvan at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From michel.sylvan at gmail.com  2008-04-10 14:16 EST -------
Aha! So that's the scope of local. I was expecting the context to be the entire
top-level, not just the single compilation unit. Thanks.

• rpmlint: OK
• package name: OK
• spec file name: OK
• package guideline-compliant: OK
• license complies with guidelines: OK
• license field accurate: OK
• license file not deleted: OK
• spec in US English: OK
• spec legible: OK
• source matches upstream: OK
• builds under >= 1 archs, others excluded: noarch
• build dependencies complete: OK
• locales handled using %find_lang, no %{_datadir}/locale: N/A
• library -> ldconfig: N/A
• relocatable: give reason: N/A
• own all directories: OK
• no dupes in %files: OK
• permission: OK
• %clean RPM_BUILD_ROOT: OK
• macros used consistently: OK
• Package contains code: OK
• large docs => -doc: N/A
• doc not runtime dependent: N/A
• headers in -devel: N/A
• static in -static: N/A
• if contains *.pc, req pkgconfig: N/A
• if libfiles are suffixed, the non-suffixed goes to devel: N/A
• devel requires versioned base package: N/A
• desktop file uses desktop-file-install: N/A
• clean buildroot before install: OK
• filenames UTF-8: OK

SHOULD
• if license text missing, ask upstream to include it: N/A
• desc and summary contain translations if available: No
• package build in mock on all architectures: OK
• package functioned as described: OK
• scriplets are sane: OK
• other subpackages should require versioned base: N/A
• if main pkg is development-wise, pkgconfig can go in main package: N/A
• require package not files: OK

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the Fedora-package-review mailing list