[Bug 433312] Review Request: opengrok - A wicked fast source browser

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: opengrok - A wicked fast source browser
Alias: opengrok-review

https://bugzilla.redhat.com/show_bug.cgi?id=433312





------- Additional Comments From lkundrak at redhat.com  2008-04-15 18:38 EST -------
> > I read somewhere, though I am not able to find the link now, that the version
> > number in patch name is one the patch was created against, and doesn't change
> > when it applies to newer upstream package.
> 
> Okay, if it was generated against 0.5 then keep it.  I guess my question is why
> it wasn't applied upstream :)  I like to keep bugs and/or rationale in comments
> to denote why we're carrying patches ... but don't worry about it if you don't
> want to do it.

Upstream is very responsive to problems so it won't be a big problem. Most of
the patches (probably with exception of Patch0 and at least of the two
addressing the issues below) are things that are specific to our build -- it can
be hardly imaginable that upstream will omit foreign jar files from the
distribution, etc. When submitting patches upstream I usually direct them to our
viewcvs, so they can eventually pick patches other that ones that I propose if 
they want to -- I'll probably do that in this case too.

> Okay, just two more things:
> 
> What's going on with this?
> 
> javadoc: error - Error while reading file
>
/home/overholt/rpmbuild/BUILD/opengrok-0.6-src/jrcs/src/java/org/apache/commons/jrcs/overview.html

Not really fatal and doesn't seem to do any harm to the build, but for it being
an annoyance I patched that away.

> And I don't think it should be trying to access the internet using hg during the
> build:
> 
> -hg-get-changeset:
>      [exec] Execute failed: java.io.IOException: Cannot run program "hg":
> java.io.IOException: error=2, No such file or directory

Right. I just commented out that target. I guess the right solution (understand:
one acceptable by upstream) would be to look for existence of .hg directory
before trying to speak upstream. (Now I realize -- maybe hg would look into the
local respoitory only, it's a distributed vcs, but I am not sure).

New bits:

http://people.redhat.com/lkundrak/SPECS/opengrok.spec
http://people.redhat.com/lkundrak/SRPMS/opengrok-0.6-8.hg275.fc8.2.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.