[Bug 439627] Review Request: gluegen - Java/JNI glue code generator to call out to ANSI C

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gluegen - Java/JNI glue code generator to call out to ANSI C


https://bugzilla.redhat.com/show_bug.cgi?id=439627





------- Additional Comments From kwizart at gmail.com  2008-04-16 10:12 EST -------
Some preliminary notes:
I cannot install F-9 for now so I won't be able to test with F-9 openJDK-1.6
Testing with java >= 1.6 for now on x86_64.

Ok the main problem with this package is about the content of make/lib/.
According to the new packaging guidelines, we have to remove the bundled .jar
and .class files.
If removed, the current package doesn't build anymore (even if using your patch
or defining ant -v -Dantlr.jar=$(build-classpath antlr) at build time.

Suggested BR and Requires:
BuildRequires: java-devel >= 1.6
BuildRequires: jpackage-utils >= 1.6
BuildRequires: ant, ant-contrib, ant-antlr (not sure for each of them).
Requires: jpackage-utils >= 1.6
Requires: java >= 1.6
I wonder if ant-antlr will be Requested at runtime; maybe others will be needed.

Suggested Group:
Group: Development/Libraries


Can you use %{_javadir} when appropriate (instead of %{_datadir}/java ).


This make me think that gluegen uses a patched version of cpptasks, and i don't
know how to force it to use the system one (if possible and relevant).

Found some patches here to support ppc build:
http://patches.ubuntu.com/by-release/extracted/debian/libj/libjogl-java/1.1.1~rc8-3/

I wonder if we need to add our $RPM_OPT_FLAGS in java packages:
gcc -c -fno-rtti -fPIC -I/usr/lib/jvm/java-1.6.0-openjdk-1.6.0.0/include
-I/usr/lib/jvm/java-1.6.0-openjdk-1.6.0.0/include/linux
/builddir/build/BUILD/gluegen/src/native/unix/UnixDynamicLinkerImpl_JNI.c
[cc] cc1: warning: command line option "-fno-rtti" is valid for C++/ObjC++ but
not for C


Since you have created a snapshot, it would be nicer if you can create a script
to make this snapshot, remove the included .jar files, and fix (executable)
permissions for most files.
LICENSE.txt will need to be bundled.

manual seems to be missing.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.