[Bug 443195] Review Request: pAgenda -A cross platform calendar and scheduler

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pAgenda -A cross platform calendar and scheduler


https://bugzilla.redhat.com/show_bug.cgi?id=443195


wolfy at nobugconsulting.ro changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |wolfy at nobugconsulting.ro
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?




------- Additional Comments From wolfy at nobugconsulting.ro  2008-04-19 06:04 EST -------
You should stick with either $RPM_BUILD_ROOT or %{buildroot} but using both in
the same spec is against the packaging policy.

There are also two small errors in the desktop file
- the Icon tag should either use the full path to the icon or the icon name
without extension (wiki:Packaging/Guidelines#desktop)
- according to the build log desktop-file-install complains because "key
"Categories" is a list and does not have a semicolon as trailing character"

The major problem is that you miss python as BR, which leads to
[wolfy at wolfy tmp]$ rpm -qlp  /home/wolfy/pAgenda-3.2-1.fc9.noarch.rpm
  /images.py
  /usr/bin/pagenda
which in turn gives
[wolfy at wolfy tmp]$ pagenda
The file "images.py" was not found, it is needed to run pAgenda

And I think there is also something else missing because once I start the
application (after rebuilding with python added as BR), on the right side I get
a page with raw HTML, which is quite different to what
http://www.pcbypaul.com/software/screens/pagenda_screen1.png looks like in the
same conditions

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.