[Bug 441072] Review Request: cwiid - Library and tools for comunicating with a wiimote

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cwiid - Library and tools for comunicating with a wiimote


https://bugzilla.redhat.com/show_bug.cgi?id=441072


mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |mtasaka at ioa.s.u-tokyo.ac.jp
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2008-04-20 12:03 EST -------
Now koji/CVS/etc seems under construction so I cannot
check binary rpms rebuilt from your srpm, however
for 0.6.00-3:

* SourceURL:
  - I recommend to use %{name} and %{version}. With this
    you won't have to change Source0 URL when version is
    upgraded.

* BuildRequires
  - Rebuild fails because "BuildRequires: desktop-file-utils"
    is missing.

* License tag for -wminput subpackage
  - License tag "GPLv2" is okay, however would you write some
    comments in the spec file to explain why this subpackage
    has the license tag?

* Compiler flags
  - Fedora specific compiler flags are not yet correctly honored.

* Directory ownership issue/Duplicate files
  - There are many warnings like:
-------------------------------------------------------------
warning: File listed twice: /etc/cwiid/wminput
warning: File listed twice: /etc/cwiid/wminput/acc_ptr
warning: File listed twice: /etc/cwiid/wminput/acc_ptr
warning: File listed twice: /etc/cwiid/wminput/buttons
warning: File listed twice: /etc/cwiid/wminput/buttons
.....................
--------------------------------------------------------------

    ! If you write the %files entry
--------------------------------------------------------------
%files
%{_libdir}/cwiid
--------------------------------------------------------------
      this contains the directory %_libdir/cwiid and all files/
      directories/etc under the directory, while 
--------------------------------------------------------------
%files
%dir %{_libdir}/cwiid
--------------------------------------------------------------
      contains the directory %_libdir/cwiid only.

* Desktop file
  - wmgui desktop file has Icon entry, however no icons seem to
    be installed?

Well, as this is NEEDSPONSOR ticket:

-------------------------------------------------------------
NOTE: Before being sponsored:

This package will be accepted with another few work. 
But before I accept this package, someone (I am a candidate) 
must sponsor you.

Once you are sponsored, you have the right to review other 
submitters' review requests and approve the packages formally. 
For this reason, the person who want to be sponsored (like you) 
are required to "show that you have an understanding 
of the process and of the packaging guidelines" as is described
on :
http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored

Usually there are two ways to show this.
A. submit other review requests with enough quality.
B. Do a "pre-review" of other person's review request
   (at the time you are not sponsored, you cannot do
   a formal review)

When you have submitted a new review request or have pre-reviewed other 
person's review request, please write the bug number on this bug report 
so that I can check your comments or review request.

Fedora package collection review requests which are waiting for someone to
review can be checked on:
http://fedoraproject.org/PackageReviewStatus/NEW.html
(NOTE: please don't choose "Merge Review")


Review guidelines are described mainly on:
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines
http://fedoraproject.org/wiki/Packaging/Guidelines
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets
------------------------------------------------------------


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.