[Bug 442244] Review Request: fotox - Program for improving image files made with a digital camera

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fotox -  Program for improving image files made with a digital camera


https://bugzilla.redhat.com/show_bug.cgi?id=442244





------- Additional Comments From adel.gadllah at gmail.com  2008-04-21 08:11 EST -------
(In reply to comment #1)
Sorry for the delay.

> Well, fotox is under rapid development and at the time I am
> writing this comment the latest version is 40. So:

Yeah now 41 is out.
 
> Would you ask the upstream developer to change installation scripts
> to autotool based ones ?
> - Current upstream-created "build" script does not accept compiler
>   option

Will ask upstream, if the don't do it I can patch it to use the flags.

> - desktop file is created under an unexpected directory
? %{_datadir}/applications 

> - Current installation process is rather manual
> Also
> - No license text is included in tarball (v40)

"MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc."

http://fedoraproject.org/wiki/Packaging/ReviewGuidelines

So should be fine.

I will build and upload an updated package in the next days.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.