[Bug 426884] Review Request: eclipse-epic - Perl Eclipse plugin

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: eclipse-epic - Perl Eclipse plugin


https://bugzilla.redhat.com/show_bug.cgi?id=426884





------- Additional Comments From overholt at redhat.com  2008-04-21 10:31 EST -------
Thanks for the submission, Mat.  Everything looks great.  I have a few
questions below.  When we clear these up, be sure to take EPIC off the
PackageRequests page on the Fedora wiki :)

- there are lots of antlr warnings - do you think these are okay?
- are there any unit tests for EPIC which we can use to verify the JDOM API changes?
- any idea what's going on with the debuginfo extraction?  I get lots of
  the following.  I'm not super-concerned, since this is gcj debuginfo
  and the chances of anyone other than gcj developers being able to use
  it successfully is low :)

  extracting debug info from
/var/tmp/eclipse-epic-0.6.22-3.fc8-root-overholt/usr/lib/gcj/eclipse-epic/org.epic.regexp_0.6.1.jar.so
  extracting debug info from
/var/tmp/eclipse-epic-0.6.22-3.fc8-root-overholt/usr/lib/gcj/eclipse-epic/org.epic.perleditor_0.6.15.jar.so
  extracting debug info from
/var/tmp/eclipse-epic-0.6.22-3.fc8-root-overholt/usr/lib/gcj/eclipse-epic/org.epic.debug_0.6.16.jar.so
  cpio:
epic-0.6.22/aot-compile-rpm/usr/lib/gcj/eclipse-epic/org.epic.debug_0.6.16.jar.1.jar:
Cannot stat: No such file or directory
  cpio:
epic-0.6.22/aot-compile-rpm/usr/lib/gcj/eclipse-epic/org.epic.perleditor_0.6.15.jar.1.jar:
Cannot stat: No such file or directory
  cpio:
epic-0.6.22/aot-compile-rpm/usr/lib/gcj/eclipse-epic/org.epic.perleditor_0.6.15.jar.2.jar:
Cannot stat: No such file or directory
  cpio:
epic-0.6.22/aot-compile-rpm/usr/lib/gcj/eclipse-epic/org.epic.regexp_0.6.1.jar.1.jar:
Cannot stat: No such file or directory
  cpio:
epic-0.6.22/aot-compile-rpm/usr/lib/gcj/eclipse-epic/org/epic/core/Constants.java:
Cannot stat: No such file or directory
  cpio:
epic-0.6.22/aot-compile-rpm/usr/lib/gcj/eclipse-epic/org/epic/core/PerlCore.java:
Cannot stat: No such file or directory

- rpmlint warnings are okay to be waived
- requires and provides look fine
- functionality seems okay but I get an error when trying to debug about
  variable display needing PadWalker.  Should we add perl-PadWalker to
  the Requires?  Even if I have that installed, I don't get variables
  when debugging.  Should I / do you?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.