[Bug 188542] Review Request: hylafax

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: hylafax


https://bugzilla.redhat.com/show_bug.cgi?id=188542





------- Additional Comments From rc040203 at freenet.de  2008-04-25 01:14 EST -------
(In reply to comment #75)
> As for the details of this failing on gcc-4.3, admittedly there's not likely
> been anyone attempt to build HylaFAX with it until now.
That's apparent :)
 
> As for other parts of the configure script that may be hardly working at all,
> etc., please do elaborate, and I'll see what I can do about getting them
> working better.
Openly said, if I were upstream, I would ditch this configure script and its
Makefile.ins underneath and replace with something more standardized. My
personal choice would be the autotools.

> That said, it builds just fine on every platform out there that I've tested it
> on, and I'm pretty sure that's more than mere luck.
Some details from my build.log:

1.
...
Looks like /usr/lib64/ccache/gcc supports the -g option.
... but not together with the -O option, not using it.

This result is plain wrong - The test trying to check for -O -g must have failed.

2. configure script doesn't acknowledge CXXFLAGS and CFLAGS.

3. 
Checking for PAM (Pluggable Authentication Module) support
... not found. Disabling PAM support

This could be a packaging bug inside of the rpm.spec - I don't know.

4.
...
Checking ZLIB support.
Using ZLIB include files from
Using pre-built ZLIB library -lz
Done checking ZLIB support.
...
No idea what this is meant to mean. Could be a parallel build issue, a configure
script failure or else ...

5.
...
Checking JBIG-in-TIFF conversion support.
./configure: line 3274: 28995 Segmentation fault      $TIFFBIN/tiffcp -c g4
misc/jbig.tif misc/foo.tif > /dev/null 2>&1
JBIG-in-TIFF conversion support not found.
...
?!? Likely a broken check in configure.

6. -I/usr/include in compiler calls:
...
/usr/lib64/ccache/gcc        -D__ANSI_CPP__ -I. -I.. -I.././regex -I.././regex
-I.././util -I/usr/include -fpic -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2
-fexceptions -fstack-protector ...

Though it doesn't have an impact in most cases, this is quite a serious bug,
because it impacts include file search order.

7. uid/gid processing:
+ make install -e FAXUSER=8690 FAXGROUP=492 SYSUSER=8690 SYSGROUP=492
BIN=/var/tmp/hylafax-5.2.2-1.fc9-root-mockbuild/usr/bin
SBIN=/var/tmp/hylafax-5.2.2-1.fc9-root-mockbuild/usr/sbin LIBD
/bin/bash ./port/install.sh  -u 8690 -g 492 -m 755 ...

This is all wrong ... the uid/gids you see above are my personal ones!






-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.