[Bug 436637] Review Request: disktype - Detect the content format of a disk or disk image

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: disktype - Detect the content format of a disk or disk image


https://bugzilla.redhat.com/show_bug.cgi?id=436637





------- Additional Comments From kwizart at gmail.com  2008-04-29 08:40 EST -------
Seems good to me.
However I wonder if we can move disktype to sbindir instead of bindir:
from the disttype man:
". Note that running disktype on device files like your hard disk will
     likely require root rights."
We usually move this kind of app to sbindir

Note that the libewf patch expect libewf header to be in /usr/local/include/libewf.h

It is currenly available in /usr/include which is the default path, so it won't
hurt. But the nicest tweak would be to use pkg-config libewf cflags and
pkg-config libewf --libs (for the libs side).
This would lead to have : in the %prep section
--------------------
sed -i -e 's|-I/usr/local/include|%(pkg-config libewf --cflags)|' Makefile
sed -i -e 's|-L/usr/local/lib||' Makefile
sed -i -e 's|-lewf|%(pkg-config libewf --libs)|' Makefile
--------------------
Note that the current version in F-9 will not handle this nicely as
openssl-devel is missing from libewf-devel (you may need to add it from
disktype, but i think it won't be required - I've asked libewf upstream to sort
this and i guess it will be removed on the next libewf bugfix update planned for
the end of the weak).
(This problem was my bad - sorry - for now it is safe to handle the way you do
until libewf is fixed - it won't be possible to link to the F-8 version anyway
as BSD advertissing close remains present).



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.