[Bug 438543] Review Request: Synopsis - Source-code introspection tool.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Synopsis - Source-code introspection tool.


https://bugzilla.redhat.com/show_bug.cgi?id=438543





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2008-04-29 12:52 EST -------
For 0.11-1: (please change EVR from next time)

* Redundant BuildRequires
  - gc-devel Requires gc so "BuildRequires: libgc" is redundant

* Requires
  - Please check all required packages are specified by Requires
    (except for library dependencies which are automatically added
     to binary rpms by rpmbuild).

    For example, %{py_sitearch}/Synopsis/Formatters/DocBook/Markup/RST.py
    contains the lines:
-------------------------------------------------------------
    10  from docutils import writers, nodes, languages
    11  from docutils.nodes import *
    12  from docutils.core import *
    13  from docutils.parsers.rst import roles
-------------------------------------------------------------
    This means synopsis should have "Requires: python-docutils".

* Macros
--------------------------------------------------------------
--with-gc-prefix=%{prefix}
--------------------------------------------------------------
  - This must be %{_prefix}

* %doc attribute
  - Files under %_docdir or %_mandir are automatically marked 
    as %doc.

* %defattr
  - We now recommend %defattr(-.root,root,-)

* Directory ownership issue
--------------------------------------------------------------
[tasaka1 at localhost ~]$ rpm -qf /usr/share/doc/synopsis-0.11/COPYING 
synopsis-0.11-1.fc9.i386
synopsis-devel-0.11-1.fc9.i386
synopsis-idl-0.11-1.fc9.i386
[tasaka1 at localhost ~]$ rpm -qf /usr/share/doc/synopsis-0.11/        
file /usr/share/doc/synopsis-0.11 is not owned by any package
[tasaka1 at localhost ~]$ 
--------------------------------------------------------------
   - The directory %_docdir/%name-%version is not owned by any package.

* Other rpmlint issue:
--------------------------------------------------------------
synopsis.i386: W: one-line-command-in-%post /sbin/ldconfig
synopsis.i386: W: one-line-command-in-%postun /sbin/ldconfig
synopsis.i386: W: unstripped-binary-or-object /usr/lib/libSynopsis.so.0.11
--------------------------------------------------------------
  Summary
  - When only calling /sbin/ldconfig is needed for %post(%postun),
    write them in one line and avoid unneeded shell execution as
--------------------------------------------------------------
%post -p /sbin/ldconfig
%posun -p /sbin/ldconfig
--------------------------------------------------------------
   - %_libdir/libSynopsis.so.XXX.YYY is not stripped. 
     /usr/lib/rpm/find-debuginfo.sh checks and strips binaries
     with execution permission only, and on Fedora generally all
     libraries in %_libdir should have 0755 permission.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.