[Bug 455654] Review Request: pads - Passive Asset Detection System

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=455654


Peter Vrabec <pvrabec at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pvrabec at redhat.com




--- Comment #2 from Peter Vrabec <pvrabec at redhat.com>  2008-08-08 12:36:47 EDT ---
$ rpmlint pads-1.2-1.fc9.src.rpm
pads.src: W: strange-permission pads.init 0755
pads.src: W: strange-permission pads.sysconfig 0640

- pads.init and pads.sysconfig might be 0644


$ rpmlint /usr/src/redhat/RPMS/i386/pads-1.2-1.fc9.i386.rpm
pads.i386: E: non-readable /etc/sysconfig/pads 0640
pads.i386: W: non-conffile-in-etc /etc/pads-ether-codes
pads.i386: W: non-conffile-in-etc /etc/pads-signature-list
pads.i386: E: non-readable /etc/pads.conf 0640
pads.i386: W: incoherent-subsys /etc/rc.d/init.d/pads $prog
pads.i386: W: incoherent-subsys /etc/rc.d/init.d/pads $prog
1 packages and 0 specfiles checked; 2 errors, 4 warnings.

- is there a reason why not 0644 for /etc/sysconfig/pads and /etc/pads.conf
- incoherent-subsys? it doesn't seem to me. prog=pads
- non-conffile-in-etc - seems ok to me

Everything else is OK.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.