[Bug 473367] Review Request: autotrust - DNSKEY trust anchor update utility that uses RFC-5011

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=473367





--- Comment #3 from Adam Tkac <atkac at redhat.com>  2008-12-01 09:12:47 EDT ---
- specfile is properly named, is cleanly written and uses macros consistently:
NO
Distribution configure flags --sysconfdir and --libdir are overriden. It
doesn't
look right for me.

What is the reason? Why you can't put configuration file directly into /etc?

Libdir flag is unusable at all, package contains no libraries.

--------------------------
- package builds in mock (Rawhide/x86_64): NO
Source is distributed with config.{guess,sub} as symlinks. It is pretty bad
because rawhide has new libtool and those symlinks are no longer valid. I
recommend to add config.{guess,sub} to package and use it and run "autoreconf
-fiv" before build to get ltmain.sh fixed

--------------------------
- rpmlint is silent: NO
$ rpmlint autotrust-0.2.0-2.fc10.src.rpm
autotrust.src: W: strange-permission autotrust.cron 0755
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

I recommend to use 644 and then install autotrust.cron with 755 perms.

--------------------------
- final provides and requires look sane: NO
I think package should Requires: anacron

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.