[Bug 473590] Review Request: libiphone - A library for connecting to Apple iPhone and iPod touch

bugzilla at redhat.com bugzilla at redhat.com
Mon Dec 1 21:55:38 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=473590





--- Comment #4 from Bill Nottingham <notting at redhat.com>  2008-12-01 16:55:37 EDT ---
(In reply to comment #3)
> > - License  - LGPLv2+ - OK
> > - License field in spec matches - ***
> > 
> > "GPLv2+ and LGPLv2+"
> > 
> > I don't actually see any GPLv2+ code in the tarball.
> 
> There was a COPYING and COPYING.LESSER file included which is why I marked it
> as such. If you think the COPYING file is irrelevant.

What's listed in the headers of the code trumps whatever COPYING files are in
the package itself.

> > If this is going to change ABI frequently without changing soname, a warning in
> > the -devel package might be nice. Then again, if nothing other than the FUSE
> > client is going to use the library, it may not be relevant.
> 
> Would the warning be contained in an included text file or in the description
> or somewhere else? I'm not sure whether the library would be used by conduit or
> rhythmbox or whether they'd use the ifuse client.

Maybe just in the README, if it's not already there.

If you don't know of any other users of the library, it's not really a big
deal.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list