[Bug 468155] Review Request: robodoc - Extract documentation from source code

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468155


Lucian Langa <cooly at gnome.eu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #1 from Lucian Langa <cooly at gnome.eu.org>  2008-12-02 01:36:02 EDT ---
Review:

OK  source files match upstream:
        b1a0e0dda99bb26623682e62f0e59051  robodoc-4.99.36.tar.bz2
OK  package meets naming and versioning guidelines.
OK  specfile is properly named, is cleanly written and uses macros
consistently.
OK  summary is OK.
OK  description is OK.
OK  dist tag is present.
OK  build root is OK.
OK  license field matches the actual license.
OK  license is open source-compatible.
OK  license text included in package.
OK  BuildRequires are proper.
OK  compiler flags are appropriate.
OK  %clean is present.
OK  package builds in mock (rawhide, x86_64).
OK  package installs properly.
OK  debuginfo package looks complete.
OK  rpmlint is silent.
OK  final provides and requires are sane:
        robodoc = 4.99.36-1.fc10
        robodoc(x86-64) = 4.99.36-1.fc10
  =
        libc.so.6()(64bit)
OK  %check is not present; no test suite upstream. I was able to run program
from the command line and generate a doc file.  
OK  no shared libraries are added to the regular linker search paths.
OK  owns the directories it creates.
OK  doesn't own any directories it shouldn't.
OK  no duplicates in %files.
OK  file permissions are appropriate.
OK  code, not content.
OK  documentation is small, so no -doc subpackage is necessary.
OK  %docs are not necessary for the proper functioning of the package.
OK  no headers.
OK  no pkgconfig files.
OK  no static libraries.
OK  no libtool .la files.


Suggestion:
Please consider preserving the timestamp of the modified file (ChangeLog).
A simple call to 'touch -r' will do.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.