[Bug 470066] Review Request: R-qtl - Quantitative trait loci (qtl) functionality for R

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=470066





--- Comment #5 from Mattias Ellert <mattias.ellert at fysast.uu.se>  2008-12-02 08:06:15 EDT ---
(In reply to comment #4)

Thank you for your review, I will comment on your objections below.

> The package must be licensed with a Fedora approved license...
>    - NOK, see below

Well, GPLv2+ is a Fedora approved license, so I see no violation on this point.
I guess your objection is not about that the the tag I used is not approved,
but that it is the wrong one. Which is really your next point. So I will
comment further below.

> The License field in the package spec file must match the actual license.
>    - The License tag is set to GPLv2+, but the actual source license
>      is GPLv2. This is true both for the LICENSE file and at least 
>      some copyright notices.

I based the tag I used on the text in the included LICENSE.txt file which says:

"This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2 of the License, or (at
your option) any later version."

I.e. this is GPLv2+. But as you pointed out all the copyright notices in the
source file comments say:

"Licensed under the GNU General Public License version 2 (June, 1991)"

So there is an inconsistency between the LICENSE.txt file and the source file
comments. Since the source file comments are more restrictive (GPLv2) than the
LICENSE.txt file (GPLv2+) I have changed the label in the spec file to GPLv2.
New versions are available here:

Spec URL: http://www3.tsl.uu.se/~ellert/R-qtl/R-qtl.spec
SRPM URL: http://www3.tsl.uu.se/~ellert/R-qtl/R-qtl-1.09-2.fc9.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.