[Bug 465646] Review Request: python-hachoir-core - Hachoir core parser

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=465646





--- Comment #4 from Orcan 'oget' Ogetbil <orcanbahri at yahoo.com>  2008-12-03 01:14:21 EDT ---
Thanks for the update. We need to have one thing corrected and I also have a
suggestion:

* I guess I should have been a little clearer. The python guidelines are
slightly different for non-setuptools packages. You are using the guidelines as
if the building is done by setuptools. Please check the setup.py file. In order
to use the setuptools you have to pass the --setuptools flag to setup.py (in
both %build and %install). 
OR alternatively,
you can follow the non-setuptools guidelines at 
     http://fedoraproject.org/wiki/Packaging/Python/Eggs
but this will require a somewhat larger modification.

? Having a closer look, I think you should include all of doc/* in %doc. Those
are files for use of graphviz and dia, and they might be useful for some
people.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.