[Bug 464781] Review Request: flexdock - Java docking UI element. First package.

bugzilla at redhat.com bugzilla at redhat.com
Wed Dec 3 14:56:09 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=464781





--- Comment #20 from D Haley <mycae at yahoo.com>  2008-12-03 09:56:07 EDT ---
Spec URL: http://dhd.selfip.com/427e/flexdock-6.spec
SRPM URL: http://dhd.selfip.com/427e/flexdock-0.5.1-6.fc9.src.rpm 

>Hmm isn't this a blocker for review ? There should be no other
>copyright/license on any fedora spec file except fedora's.
Gone. I thought this was part of the package licence's requirements -- but its
not.

>#001: Missing BuildRequires: ant-commons-logging
Fixed.

>#002: Rpmlint issues;
rpmlint for SRPM,spec and RPM are empty.

>#001: missing ant-commons-logging as Build Requires
Fixed.
>#002: add -verbose to ant
Added, but this produces an extremely long output -- significantly greater than
the scrollback on my terminal. Not good for building unless you (1) log or (2)
redirect or both.


Known issues:
*I am not actually removing the skinlf jar, as the code to do this is commented
out. I discussed this with akurtakov previously & will revisit this soon.


* Thu Dec 04 2008 <mycae(a!t)yahoo.com> 0.5.1-6
- Use ant to build jar, rather than straight from bash.
- Fix build patch to correct native .so building
- Thanks goes to akurtakov for assitance.
- Fixed dos->unix line ending for doc files
- Added dos2unix buildrequires
- Fix arch flag
- Added libX11 dep for native so
- Added symlink for so

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list