[Bug 458784] Review Request: xcb-util - The xcb-util module provides a number of libraries which sit on top of libxcb

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=458784





--- Comment #13 from Michal Nowak <mnowak at redhat.com>  2008-12-04 07:31:09 EDT ---
(In reply to comment #12)
> You didn't picked the summaries from Comment #6?

Now I do. Thx for them.

> Otherwise rpmlint is right, given that known problem is fixed upstream:
> xcb-util.i386: W: shared-lib-calls-exit /usr/lib/libxcb-aux.so.0.0.0
> exit at GLIBC_2.0
> xcb-util-devel.i386: W: no-documentation

In -2 I have a patch for this from upstream git.

> * follow guidelines
> * free software, license corrected, not included, but not included upstream
> either

It is included. (The copyright patch.)

> * library rightly packaged
> * match upstream
> 4b06006e438c3926d077439b31d290d6  xcb-util-0.3.1.tar.bz2
> * %files section right
> * sane provides
> 
> 2 issues:
> URL should be http://xcb.freedesktop.org/

Fixed.

> source tarball timestamp not kept:
> -rw-rw-r-- 1 dumas dumas 265979 nov. 24 00:33 ../SOURCES/xcb-util-0.3.1.tar.bz2
> -rw-rw-r-- 1 dumas dumas 265979 nov. 20 15:36 xcb-util-0.3.1.tar.bz2

Should be in -2.

> APPROVED if you fix the 2 issues.

Please, do so.

--
http://www.stud.fit.vutbr.cz/~xnowak01/Fedora/xcb-util/xcb-util.spec

http://www.stud.fit.vutbr.cz/~xnowak01/Fedora/xcb-util/xcb-util-0.3.1-2.el5.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.