[Bug 474606] Review Request: SolarModel - Realtime 3D Solar System simulation

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=474606


Lubomir Rintel <lkundrak at v3.sk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #1 from Lubomir Rintel <lkundrak at v3.sk>  2008-12-04 17:58:46 EDT ---
Well done!

* SPEC file is clean, legible. RPMlint produces no errors and warnings.
(I think "Realtime" (in Summary) is correctly spelled "Real-time" in American
English, but I'm not sure since I'm not a native speaker.)

* Built in fedora-5-i386-epel mock (irrlicht packages pulled in manually)
successfully with after a tiny 32bit-specific fix applied (I assume x86_64
builds fine). Anyways, BRs are connect.

To build this on i386 a small change is needed, since the length of a light
year won't fit in a 32bit doubleword (sorry about the light breaks, but it's
trivial to apply this by hand anyways):

diff -up SolarModel_src/GameMeasurer.cpp.int SolarModel_src/GameMeasurer.cpp
--- SolarModel_src/GameMeasurer.cpp.int 2008-12-04 21:03:05.000000000 +0100
+++ SolarModel_src/GameMeasurer.cpp     2008-12-04 21:11:32.000000000 +0100
@@ -313,7 +313,7 @@ core::stringw GameMeasurer::GetDistanceA
                        distanceKM/9460730472581.0f);

                swprintf(s, (sizeof(s)/sizeof(s[0])), L"%.0lf km%s%s",
-                       distanceKM, distanceKM>149598?au:L"",
distanceKM>9460730473?ly:L"");
+                       distanceKM, distanceKM>149598?au:L"",
distanceKM>9460730473LL?ly:L"");
        }

        return core::stringw(s);

It won't block the approval, since at the packages are required to build on at
least one architecture, and I don't see why won't this build on x86_64.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.