[Bug 474744] Review Request: supybot-fedora - Plugin for Supybot to interact with Fedora services

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=474744


manuel wolfshant <wolfy at nobugconsulting.ro> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |wolfy at nobugconsulting.ro
               Flag|                            |fedora-review?




--- Comment #2 from manuel wolfshant <wolfy at nobugconsulting.ro>  2008-12-05 05:48:31 EDT ---
there are several tiny problems:
- the correct Source0 is
https://fedorahosted.org/releases/s/u/%{name}-%{version}.tar.bz2https://fedorahosted.org/releases/s/u/%name/%{name}-%{version}.tar.bz2
- the spec file name as included in the src.rpm should be supybot-fedora, not
supybot-koji
- %install lacks rm -rf $RPM_BUILD_ROOT


Otherwise things seem pretty much OK, please come back with a correct src.rpm
and I'll do a full review

PS: is BR python-devel really needed?
http://fedoraproject.org/wiki/Packaging/Python claims BR: python is enough

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.