[Bug 474802] Review Request: vacation - Automatic mail answering program

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=474802


Rex Dieter <rdieter at math.unl.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rdieter at math.unl.edu




--- Comment #1 from Rex Dieter <rdieter at math.unl.edu>  2008-12-05 08:53:29 EDT ---
Quick comments:
1.  (minor) use prefered/standard Group: and BuildRoot: (see Packaging
guidelines for details).
2.  %build:  use 
make CFLAGS="$RPM_OPT_FLAGS"
3.  install usage: use -p flag (preserve timestamps), do *not* use -s (strip)
4.  imo, the %post, %postun scriptlets are unwise/broken.  My home-brewed
vacation pkgs always included the /etc/smrsh/vacation symlink in the package. 
But that means vacation Requires: sendmail , I'm unware if it works with other
mailers.  If so, then perhaps a %trigger sendmail would work better.
5.  %files: use
%defattr(-,root,root,-)
then you don't need to manually use %attr everwhere

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.