[Bug 459210] Review Request: gnustep-base - GNUstep base package

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459210





--- Comment #4 from manuel wolfshant <wolfy at nobugconsulting.ro>  2008-12-05 19:35:11 EDT ---
There seems to be a missing BR for some ssl-devel:
  checking openssl/ssl.h usability... no
  checking openssl/ssl.h presence... no
  checking for openssl/ssl.h... no
  configure: WARNING: SSL bundle will not be built: Could not find openssl
libraries
Is this intentional? Because if it builds with it, it should be included.

Ref: devel
1. Why is "/usr/include/gnu-gnu-gnu" used as directory for include files (in
-devel) ? I'd say that /usr/include/gnustep would look more "normal". After a
quick glance over http://www.gnustep.org/experience/documentation.html I have
not found any reference for "gnu-gnu-gnu".
2. %{_libdir}/GNUstep/Makefiles/ and /usr/lib64/GNUstep/Makefiles/Additional/
are unowned


Ref: base
I have built the package in mock on an x86_64 and I think that there are some
issues:
3. Why is /usr/lib/x86_64/linux-gnu/gnu-gnu-gnu/ used and not
/usr/lib64/gnustep ?
4. The name "pl" (/usr/bin/pl) is not really acceptable, under the terms of
http://fedoraproject.org/wiki/PackageMaintainers/Packaging_Tricks#Use_of_common_namespace
5. docs should be built by default unless there is a very compelling reason to
not do it.

rpmlint has also a complaint about mixed use of spaces and tabs, please be as
kind as to fix it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.