[Bug 459212] Review Request: oolite-data - Data files for Oolite

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459212


manuel wolfshant <wolfy at nobugconsulting.ro> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |wolfy at nobugconsulting.ro
               Flag|                            |fedora-review?




--- Comment #1 from manuel wolfshant <wolfy at nobugconsulting.ro>  2008-12-05 19:02:40 EDT ---
Nothing much to review here, as it's just a bunch of data...
GOOD:
====
SHA1sum corresponds with upstream
  c322fa81a57d39e150806917cb052bb370efa725 oolite-1.65-data.tar.gz
license is OK ( GPLv2+ )
builds fine in mock 

Potential problems
==================
rpmlint output:
Source RPM:
oolite-data.src:32: E: hardcoded-library-path in
%{_prefix}/lib/GNUstep/Applications/oolite.app/Contents
oolite-data.src:33: E: hardcoded-library-path in
%{_prefix}/lib/GNUstep/Applications/oolite.app/Contents/
oolite-data.src:43: E: hardcoded-library-path in
%{_prefix}/lib/GNUstep/Applications/oolite.app/Contents/Resources/*
--> What is the are these required by the game or

oolite-data.src: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 12)
1 packages and 0 specfiles checked; 3 errors, 1 warnings.
--> esthetic bug, please fix before commit

rpmlint of oolite-data:
oolite-data.noarch: E: only-non-binary-in-usr-lib
--> normal, as we have just data

MUSTFIX
=======
the folders below /usr/lib/GNUstep/Applications/oolite.app/ seem to be left
unowned and at the first glance oolite does not own them either.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.