[Bug 469527] Review Request: tcping - Check of TCP connection to a given IP/Port

bugzilla at redhat.com bugzilla at redhat.com
Sat Dec 6 13:15:14 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469527





--- Comment #5 from Fabian Affolter <fabian at bernewireless.net>  2008-12-06 08:15:12 EDT ---
(In reply to comment #1)
> This code seems to be confused about how it is licensed.  Note that the LICENSE
> file contains the LGPL (v2) but the code itself says:
>  * This code may be freely redistributed under the terms of the
>  * GNU General Public License.
> and this agrees with the README:
>   This software may be freely distributed under the terms of
>   the GNU General Public License (GPL).
> 
> No version is specified anywhere, so GPL+ would seem to apply.  Can you clarify
> with upstream?

For the moment I changed the license to GPL+ while I'm waiting for an answer
from upstream.

> This also suffers from the compiler flags problem; easily fixed by changing the
> make line to:
>   make CCFLAGS="%{optflags}" %{?_smp_mflags}

fixed

Here are the new files.

Spec URL: http://fab.fedorapeople.org/packages/SRPMS/tcping.spec
SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/tcping-1.3.4-2.fc9.src.rpm

Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=983765

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list