[Bug 474992] Review Request: libirman - Library for IRMAN hardware

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=474992


Fabian Affolter <fabian at bernewireless.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fabian at bernewireless.net




--- Comment #1 from Fabian Affolter <fabian at bernewireless.net>  2008-12-06 08:54:19 EDT ---
Just some quick comments on your spec file

- 'Release: 3%{?dist}' should be 'Release: 1%{?dist}' and your changelog entry
doesn't match the release.
  https://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs

 [fab at laptop024 i386]$ rpmlint libirman*
 libirman.i386: W: incoherent-version-in-changelog 0.4.4-2 ['0.4.4-3.fc9',
'0.4.4-3']
 3 packages and 0 specfiles checked; 0 errors, 1 warnings.

- URL should point to the website of the upstream project.  Why not
http://www.lirc.org/ ?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.