[Bug 474815] Review Request: perl-AutoXS-Header - Container for the AutoXS header files

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=474815


Jason Tibbitts <tibbs at math.uh.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
               Flag|                            |fedora-review+




--- Comment #1 from Jason Tibbitts <tibbs at math.uh.edu>  2008-12-06 17:56:10 EDT ---
This fails to build; the tests bomb because you're missing a build dependency
on Test::More.  Please do mock or koji scratch builds of packages before
submitting them.  I fixed that so that I can complete this review.  Since I
didn't find any other issues, I'll go ahead and approve this, but of course
you'll have to fix that so you can build in koji.

* source files match upstream.  sha256sum:
   59ee972bf0ea3e85fbcb619863e2cd47ad5646a849409c9a65123fffdb77519a  
   AutoXS-Header-0.03.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
X BuildRequires missing Test::More.
* %clean is present.
* package builds in mock (rawhide, x86_64) after fixing BuildRequires.
* package installs properly.
* rpmlint is silent.
* final provides and requires are sane:
   perl(AutoXS::Header) = 0.03
   perl-AutoXS-Header = 0.03-1.fc11
  =
   perl >= 0:5.006
   perl(:MODULE_COMPAT_5.10.0)
   perl(strict)
   perl(warnings)

* %check is present and all tests pass:
   All tests successful.
   Files=1, Tests=3,  0 wallclock secs ( 0.00 usr  0.00 sys +  0.01 cusr  0.00 
    csys =  0.01 CPU)

* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED, but of course you'll have to fix the dependencies so it builds.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.