[Bug 474867] Review Request: perl-B-Utils - Helper functions for op tree manipulation

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=474867


Jason Tibbitts <tibbs at math.uh.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
               Flag|                            |fedora-review+




--- Comment #1 from Jason Tibbitts <tibbs at math.uh.edu>  2008-12-06 18:28:06 EDT ---
Not much to say here.  I agree that the rpmlint complaint is OK, as
occasionally a single internal header file comes as part of a binary Perl
module.

One of the tests is skipped due to a lack of Test::Signature, but honestly
verifying signatures as part of the test suite isn't useful in all cases.  If
we need to patch a file, for example, the tests would fail.

* source files match upstream.  sha256sum:
   b2609a722def7499952831f4a72fd0bf6786e64414bd74607cd89637bbb2d59a
   B-Utils-0.07.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* debuginfo package looks complete.
* rpmlint has acceptable complaints.
* final provides and requires are sane:
   Utils.so()(64bit)
   perl(B::Utils) = 0.07
   perl(B::Utils::Install::Files)
   perl(B::Utils::OP) = 0.07
   perl-B-Utils = 0.07-1.fc11
   perl-B-Utils(x86-64) = 0.07-1.fc11
  =
   perl >= 0:5.006
   perl(:MODULE_COMPAT_5.10.0)
   perl(B)
   perl(B::Utils)
   perl(Carp)
   perl(Exporter)
   perl(Scalar::Util)
   perl(base)
   perl(strict)
   perl(subs)
   perl(vars)
   perl(warnings)

* %check is present and all tests pass:
   All tests successful.
   Files=22, Tests=136,  1 wallclock secs ( 0.06 usr  0.03 sys +  0.54 cusr  
    0.08 csys =  0.71 CPU)

* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.