[Bug 473530] Review Request: constantine - Platform Constants for Java

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=473530


Jason Tibbitts <tibbs at math.uh.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
               Flag|                            |fedora-review?




--- Comment #2 from Jason Tibbitts <tibbs at math.uh.edu>  2008-12-06 20:38:10 EDT ---
It's been a while since I reviewed a java package.  This one seems simple and
clean enough.  I note, though, that you don't include the gcj aot bits as 
http://fedoraproject.org/wiki/Packaging/GCJGuidelines suggests.  Frankly I
don't know enough about the Java situation to argue either way; on one hand, my
understanding is that we still have platforms which benefit from native code
generation, but on the other hand this package exists primarily for jruby which
doesn't do the aot stuff either.  Anyway, it isn't a blocker.

rpmlint says:
  constantine.noarch: W: no-documentation
which normally would be OK, except that in this case at least the LICENSE file
should be included.

Regarding the test suite, it would of course be good to run it, but if it
doesn't work without hacks then I certainly can't fault you

So the only blocker I see is the inclusion of the license file.

* source files match upstream.  sha256sum:
   f12bb1820fdcb30464929e605b5181c8ea95e9eea8294b86c00b15d7a9431c74  
   constantine-src-0.4.zip
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
X license text not included in package.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* final provides and requires are sane:
   constantine = 0.4-1.fc11
  =
   java
   jpackage-utils

* no duplicates in %files.
* file permissions are appropriate.
* code, not content.
* %docs are not necessary for the proper functioning of the package.

Java-specific bits:
* no pre-built jars
* single jar, named after the package
* jarfiles are under _javadir.
* ant called properly.

The package review process needs reviewers!  If you haven't done any package
reviews recently, please consider doing one.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.