[Bug 458254] Review Request: fedora-package-config-zypper - Repository configuration for zypper

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=458254


Fabian Affolter <fabian at bernewireless.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fabian at bernewireless.net




--- Comment #3 from Fabian Affolter <fabian at bernewireless.net>  2008-12-08 06:33:42 EDT ---
Just some quick comments on your spec file

- Don't mix $RPM_BUILD_ROOT and %{buildroot}
 
https://fedoraproject.org/wiki/Packaging/Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS

- URL is not the upstream URL.  Why not pack the file together and make a
proper release which is hosted on fedorahosted.org?

- &doc is empty.  Is it necessary?

Zypper is not available for Fedora at the moment.  Does it make sense to add
*.repo files without the tool to use them?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.