[Bug 475000] Review Request: cmconvert - CacheMate import file converter

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=475000


Fabian Affolter <fabian at bernewireless.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fabian at bernewireless.net




--- Comment #2 from Fabian Affolter <fabian at bernewireless.net>  2008-12-08 09:29:21 EDT ---
My comments for this spec file are very similar to the comments in #474768 .

- 'Source0: %{name}-%{version}.tar.gz' should point to the upstream, when
possible. 
  https://fedoraproject.org/wiki/Packaging/SourceURL

- Don't mix $RPM_BUILD_ROOT and %{buildroot}
 
https://fedoraproject.org/wiki/Packaging/Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.