[Bug 473184] Review Request: clamz - Amazon Downloader

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=473184





--- Comment #4 from Fabian Affolter <fabian at bernewireless.net>  2008-12-08 18:49:46 EDT ---
(In reply to comment #3)
> (In reply to comment #1)
> > - Spec file name should be clamz.spec
> 
> Why?  Then I can't keep all the previous links valid.  FWIW, I've done this
> before without complaint.

https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Spec_file_name

You haven't to keep the links valid, just add a proper entry in the %changelog
section.  The number in the 'Release:' tag is 4 but there is only one entry in
the changelog.

https://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs

> > - Add README to %doc
> 
> Hmm, already there; I'm going to guess you meant COPYING.

I can't remember, but it's possible that I took the wrong file.

About the .desktop file.  The guidelines says that it should be include as
'SourceX:' https://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files

I think with the .xml file the procedure will be similar.  Send these files to
upstream and ask them to include those files in a future release of clamz.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.