[Bug 471805] Review Request: aespipe - AES-based encryption tool for tar/cpio and loop-aes images

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=471805


Till Maas <opensource at till.name> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |opensource at till.name
         AssignedTo|nobody at fedoraproject.org    |opensource at till.name
               Flag|                            |fedora-review?




--- Comment #6 from Till Maas <opensource at till.name>  2008-12-10 11:35:25 EDT ---
- The tools execves to gpg, therefore a Requires: gpg should be added
- The package contains a testsuite, please add this to the spec to run it:
%check
make tests
- Then you probably also need "BuildRequires: gpg"
- The package does not build on ppc(64):
http://koji.fedoraproject.org/koji/taskinfo?taskID=991182
The problem is, that you have to run make without a target on ppc(64). You can
do this by defining a helper macro, e.g.

%define make_target %{nil}

%ifarch x86_64
%define make_target amd64
%endif

%ifarch %{ix86}
%define make_target x86
%endif

make %{?_smp_mflags} %{make_target}

- Also note the added "%{?_smp_mflags}", which seem to work fine here.
- Have you thought about patching Makefile.in at upstream to use your install
commands instead of cp? Then you can use "make install DESTDIR=%{buildroot}"
beginning with next upstreams release. I can probably help you with this, if
you need help.

- Maybe you should use Source0: instead of Source:, but it seems not to cause
any trouble. I believe I have read some changes about Patch:/Patch0: with the
new rpm, but I have to check this.
- The guidelines recommend a  %defattr(-, root, root, -) instead of %defattr(-,
root, root, 0755), but I guess the latter is a better %defattr, but I have to
check this, too

I will try to make a complete review later.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.