[Bug 474908] Review Request: xmms2 - A modular audio framework and plugin architecture

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=474908


Orcan 'oget' Ogetbil <orcanbahri at yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #3 from Orcan 'oget' Ogetbil <orcanbahri at yahoo.com>  2008-12-10 17:31:30 EDT ---
Thanks for the update. The package is good to go now.

Btw, the following issues may need to be re-addressed by your friend for the
freeworld package ;)

> ? Some files in the wafadmin directory have /usr/local/ /usr/lib/ directories
> hardcoded. Will these have any effect on the application?

> * Please add the -v flag to the waf script so we can see what it is actually
> doing. When I did this, I found that the fedora specific compiler flag -O2 is
> being overwritten. This needs fixed.

> * Double BR: libmodplug-devel

> * Unnecessary BRs: libcurl-devel (picked up by ecore-devel), glib2-devel
> (picked up by avahi-glib-devel, pulseaudio-libs-devel...), libogg-devel,
> libvorbis-devel (both picked up by libshout-devel), python-devel (picked up by
> Pyrex)


----------------------------------------
This package (xmms2) is APPROVED by oget
----------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.