[Bug 226508] Merge Review: tvtime

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226508


Lucian Langa <cooly at gnome.eu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cooly at gnome.eu.org




--- Comment #1 from Lucian Langa <cooly at gnome.eu.org>  2008-12-11 01:39:01 EDT ---
Rpmlint is not silent:

tvtime.src: W: patch-not-applied Patch0: tvtime-0.9.13-pie.patch
tvtime.x86_64: E: non-standard-executable-perm
/usr/share/locale/sv/LC_MESSAGES/tvtime.mo 0775
tvtime.x86_64: W: file-not-utf8 /usr/share/man/es/man1/tvtime-scanner.1.gz
tvtime.x86_64: E: non-standard-executable-perm
/usr/share/locale/de/LC_MESSAGES/tvtime.mo 0775
tvtime.x86_64: E: non-standard-executable-perm /usr/bin/tvtime 0775
tvtime.x86_64: E: non-standard-executable-perm
/usr/share/locale/nl/LC_MESSAGES/tvtime.mo 0775
tvtime.x86_64: E: non-standard-executable-perm
/usr/share/locale/ru/LC_MESSAGES/tvtime.mo 0775
tvtime.x86_64: E: non-standard-executable-perm
/usr/share/locale/ko/LC_MESSAGES/tvtime.mo 0775
tvtime.x86_64: E: non-standard-executable-perm
/usr/share/locale/cs/LC_MESSAGES/tvtime.mo 0775
tvtime.x86_64: E: non-standard-executable-perm
/usr/share/locale/nn/LC_MESSAGES/tvtime.mo 0775
tvtime.x86_64: W: file-not-utf8 /usr/share/man/es/man5/stationlist.xml.5.gz
tvtime.x86_64: W: file-not-utf8 /usr/share/man/es/man1/tvtime.1.gz
tvtime.x86_64: E: non-standard-executable-perm
/usr/share/locale/pt/LC_MESSAGES/tvtime.mo 0775
tvtime.x86_64: W: file-not-utf8 /usr/share/man/es/man1/tvtime-configure.1.gz
tvtime.x86_64: E: non-standard-executable-perm
/usr/share/locale/es/LC_MESSAGES/tvtime.mo 0775
tvtime.x86_64: W: file-not-utf8 /usr/share/man/es/man5/tvtime.xml.5.gz
tvtime.x86_64: W: file-not-utf8 /usr/share/doc/tvtime-1.0.2/AUTHORS
tvtime.x86_64: E: non-standard-executable-perm
/usr/share/locale/hu/LC_MESSAGES/tvtime.mo 0775
tvtime.x86_64: E: non-standard-executable-perm
/usr/share/locale/fr/LC_MESSAGES/tvtime.mo 0775
tvtime.x86_64: E: non-standard-executable-perm
/usr/share/locale/fi/LC_MESSAGES/tvtime.mo 0775
tvtime.x86_64: E: non-standard-executable-perm
/usr/share/locale/pl/LC_MESSAGES/tvtime.mo 0775

Consider also using the standard sourceforge url in Source:
http://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net

Please use default %defattr in %files
%defattr(-, root, root, -)

Please see desktop file install:
http://fedoraproject.org/wiki/Packaging/Guidelines#desktop-file-install_usage

desktop file needs some work
net-tvtime.desktop: warning: key "Encoding" in group "Desktop Entry" is
deprecated
net-tvtime.desktop: warning: value "tvtime.png" for key "Icon" in group
"Desktop Entry" is an icon name with an extension, but there should be no
extension as described in the Icon Theme Specification if the value is not an
absolute path
net-tvtime.desktop: warning: value "Application;AudioVideo;" for key
"Categories" in group "Desktop Entry" contains a deprecated value "Application"

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.