[Bug 474910] Review Request: esperanza - A graphical audio player

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=474910


Orcan 'oget' Ogetbil <orcanbahri at yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |orcanbahri at yahoo.com
         AssignedTo|nobody at fedoraproject.org    |orcanbahri at yahoo.com
               Flag|                            |fedora-review?




--- Comment #1 from Orcan 'oget' Ogetbil <orcanbahri at yahoo.com>  2008-12-11 03:39:50 EDT ---
Let's make xmms2 a little more useful. Here's my notes:

- rpmlint says:
    esperanza.src:28: W: configure-without-libdir-spec
but I guess this can be safely ignored.

* There are binary translation files (.qm) in the tarball which need to be
removed and rebuilt (via lrelease).

? Where are these translations going? Are they getting compiled into the final
binary?

? I think the files data/text/*.html need to go to %doc (if they are not
getting compiled into the binary but I couldn't find them within the
application)

* Fedora specific flag "-fexceptions" is not passed to the compiler. The other
flags are ok.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.